Enhancement #442
Invitations should allow multilines and carriadge return
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | - | Estimated time: | 0.00 hour | |
| Target version: | - | |||
| Resolution: | Tags: | easy |
Description
Feedback of @johnarupire (in Spanish):
al momento de realizar invitaciones si no usas el mouse no puedes meter más de una dirección de correo en el cajón, ya que al presionar la tecla intro la invitación se envía y la ventana se cierra. Al abrir la ventana se muestran 3 direcciones como ejemplo y eso da la sensación de que se podría enviar muchas invitaciones al mismo tiempo...
Hey! aquí si funciona la tecla Intro para saltar de línea! estaría bien que en la ventana de invitaciones pasara lo mismo ;)
Associated revisions
Fix #442: invitations allow multilines
History
#1
Updated by Vicente J. Ruiz Jurado over 11 years ago
- Tags set to easy
AbstractInvitationConfirmDialog extends BasicTopDialog and should extends (maybe) PromptTopDialog. FeedbackBottomPanel allow this.
#2
Updated by Samer - over 11 years ago
It's true this is easy (solved commenting line in onEnter in AbstractInvitateAction). However, when inserting an enter in the field, the regular expression is not matched (it expects a list of emails separated by commas... without newlines). I was going to change the regex to accept enter but... are we sure we want to do that?
I wouldn't allow enters if they are not in the regex, as it's confusing for the user why the list of emails is not allowed. Besides, you can always write a list of emails separated by commas and it will jump line automatically, without enters. Thus:- if we don't want to modify the regex, we close this issue as wontfix.
- if we want, please express it and I'll do so.
#3
Updated by Vicente J. Ruiz Jurado over 11 years ago
Modifying the regexp with \\s (aka any kind of space) should fix it:
http://stackoverflow.com/questions/6359810/java-regex-checking-for-carriage-return
#4
Updated by Samer - over 11 years ago
Sorry, I didnt mean you need to search for me the regex (it was easy to find it). By "express it" I just meant to "express" agreement :P
Anyway, patch for this:
http://reviews.comunes.org/r/7/
#5
Updated by Samer - over 11 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset 40ca20d824869d9236b3c676c93627e27a23ac4f.